API for Next Hop Strategy rebind during a transaction #12512
Conversation
traeak
changed the title
traeak
force-pushed
the
strategy_rebind
branch
2 times, most recently
from
4009100 to
1d2557d
Compare
traeak
force-pushed
the
strategy_rebind
branch
from
23edfb3 to
4805259
Compare
This adds 'c' friendly api calls to get and set strategies, to get the name of a given strategy and to get a strategy from the strategy factory by name. Also includes additions to header_rewrite, regex_remap and lua plugins.
traeak
force-pushed
the
strategy_rebind
branch
from
a5939e5 to
8c1b741
Compare
|
Did you email the mailing list with the new API additions ? |
|
I think more tests need to be added for corner cases. Also on request am working on setting up a stress test case to ensure that converting the strategy shared_ptr to plain pointers doesn't result in faults. |
|
@jrushford Hey, do you want to take a look at this PR for us? |
|
@bryancall Yes, I've been talking with Bryan about it. I'll take a look but, give me a day as I'm currently traveling. |
+1 on more stress testing. I was worried that changing from shared_ptr to plain pointers might result in memory leaks or crashes when remap.config and strategies.yaml is reloaded. So far though it looks good to me. I'll spin up some VM's and test it. |
|
I stress tested using real time traffic replay (with strategies enabled), constantly forcing reloads every few seconds for several hours. I didn't observe any hiccups or issues. (A shame tsan is messy at the moment). Chris' presentation during the summit seemed to agree with my assessment that UrlRewrite which holds the StrategyFactory lives as long as any active transaction are still around, ensuring the strategies live as long as necessary. |
4 participants
This adds to the ts api to allows the selected parent strategy to be changed during a transaction using a 'c' friendly API.
APIs added:
Set and get via strategy pointer.
Gets the name of the provided strategy
The below looks up a strategy by name by using the current transaction to get to the NextHopStrategyFactory.
Support added to:
Ideally there also should be a way to make the NextHopStrategyFactory pointer directly available to TSRemapNewInstance.